Remove Bootstrap print, responsive-embed, and media styles. #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
refactor/remove-bootstrap-style-utils
branch
from
89d03f8
to
46c3eac
Compare
|
The print styles are actually used anytime someone tries to print a page, no? Not that we've actually made any attempt to make any of the Kibana pages printable, so it's still probably fine to delete them. |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
|
@Bargs You're right and that was my line of thought, too. We should probably add specific styles to make very specific parts of Kibana look good in print, as the need arises. |
|
@cjcenizal agreed, LGTM |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…rap-style-utils Remove Bootstrap print, responsive-embed, and media styles. Former-commit-id: e0bc46a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't look like these are used by either Kibana or X-Pack.